Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - check that benches build #2675

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - check that benches build #2675

wants to merge 3 commits into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Adds a job that runs cargo check --benches

@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Aug 18, 2021
@cart
Copy link
Member

cart commented Aug 26, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 26, 2021
@mockersf
check that benches build (#2675)
9dd29a5 
# Objective

- Fixes #2674 
- Check that benches build

## Solution

- Adds a job that runs `cargo check --benches`
@bors
Copy link
Contributor

bors bot commented Aug 26, 2021

Build failed:

mockersf and others added 3 commits August 25, 2021 17:17
@mockersf @cart
check that benches still build
e3cb096
@mockersf @MinerSebas @cart
removed unused components
6eaca55 
Co-Authored-By: MinerSebas <66798382+MinerSebas@users.noreply.github.com>
@cart
fix benchmark build
531afe5
@cart
Copy link
Member

cart commented Aug 26, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 26, 2021
@mockersf @cart
check that benches build (#2675)
f6b42b8 
# Objective

- Fixes #2674 
- Check that benches build

## Solution

- Adds a job that runs `cargo check --benches`


Co-authored-by: Carter Anderson <mcanders1@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 26, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title check that benches build [Merged by Bors] - check that benches build Aug 26, 2021
@bors bors bot closed this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinerSebas MinerSebas MinerSebas left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure that benchmarks continue to compile
4 participants
@mockersf @cart @alice-i-cecile @MinerSebas